Fix merge_features crash on empty DataFrame input - #45
Merged
Conversation
Co-authored-by: kheal <10502759+kheal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix merge_features to handle empty DataFrame
Fix Mar 10, 2026
merge_features crash on empty DataFrame input
kheal
marked this pull request as ready for review
March 10, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge_featuresraisedValueError: zero-size array to reduction operation maximum which has no identitywhen passed an empty DataFrame, because it unconditionally calledvalues.max()before checking whether the array had any elements.Changes
deimos/alignment.py: Added an early-return guard inmerge_features— if the input DataFrame is empty, return it immediately before any distance computation:tests/test_alignment.py: Addedtest_merge_features_pass_noneandtest_merge_features_emptyto cover theNoneand empty-DataFrame paths.Example
Original prompt
merge_featuresfails with empty DataFrame #44💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.