fix shell injection upon calling pdftk - #6
Open
ntevenhere wants to merge 1 commit into
Open
Conversation
I came across an error like this:
```
$ pdfoutliner toc.txt --inpdf "(John Smith) IRS.pdf" --outpdf '(John Smith) IRS new.pdf'
sh: 1: Syntax error: "(" unexpected
```
Again the argument is easily intepreted as a shell command, which easily causes trouble:
```
$ pdfoutliner toc.txt --inpdf "IRS.pdf" --outpdf '; exit'
Error: Failed to open output file:
/home/user/
No output created.
No output created.
```
(I should be able to name a file '; exit' if I want to)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across an error like this:
Again the argument is easily intepreted as a shell command, which easily causes trouble:
(I should be able to name a file '; exit' if I want to)