Skip to content

fix: normalize Binance feed symbol case - #2420

Open
Anikesh348 wants to merge 1 commit into
pmxt-dev:mainfrom
Anikesh348:feature/normalize-binance-symbol-case
Open

Anikesh348 wants to merge 1 commit into
pmxt-dev:mainfrom
Anikesh348:feature/normalize-binance-symbol-case

Conversation

@Anikesh348

Copy link
Copy Markdown

Summary

  • normalize Binance feed symbols before cached ticker lookup and subscription matching
  • add regression coverage for lowercase fetchTicker and watchTicker inputs

Verification

  • node node_modules/jest/bin/jest.js --config core/jest.config.js core/test/unit/dataFeeds.core.test.ts --runInBand (5 tests passed)
  • node node_modules/typescript/bin/tsc --project core/tsconfig.json --noEmit
  • git diff --check

Limitations

  • I did not run the full monorepo test suite; validation was scoped to the affected core feed tests and the complete core TypeScript compile check.

Closes #2415

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BinanceFeed doesn't normalize symbol case — fetchTicker/watchTicker silently hang then time out for non-canonical-case symbols

1 participant