Skip to content

fix(ts-sdk): use shared transport for market comparison - #2030

Open
Purin1410 wants to merge 1 commit into
pmxt-dev:mainfrom
Purin1410:fix/1485-router-transport
Open

fix(ts-sdk): use shared transport for market comparison#2030
Purin1410 wants to merge 1 commit into
pmxt-dev:mainfrom
Purin1410:fix/1485-router-transport

Conversation

@Purin1410

Copy link
Copy Markdown

Summary

  • Route Router.compareMarketPrices through the shared sidecar read transport.
  • Add dynamic URL resolution, connection retries, and the existing compatibility fallback without changing response mapping.

Test plan

  • npm test --workspace=pmxtjs -- --runInBand tests/router-compareMarketPrices.test.ts
  • npm test --workspace=pmxtjs -- --runInBand
  • npm run build --workspace=pmxtjs
  • git diff --check origin/main...HEAD

Fixes #1485

@Purin1410
Purin1410 marked this pull request as ready for review August 12, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK drift: compareMarketPrices bypasses the shared retrying transport in TypeScript, unlike Python and unlike its own TS sibling Router methods

1 participant