Skip to content

fix(ts-sdk): exclude null price changes from filters - #2028

Closed
Purin1410 wants to merge 1 commit into
pmxt-dev:mainfrom
Purin1410:codex/fix-1524-null-price-change
Closed

fix(ts-sdk): exclude null price changes from filters#2028
Purin1410 wants to merge 1 commit into
pmxt-dev:mainfrom
Purin1410:codex/fix-1524-null-price-change

Conversation

@Purin1410

Copy link
Copy Markdown

Summary

  • Exclude an explicit null priceChange24h from price-change filters.
  • Preserve numeric zero values and add a regression test for the distinction.

Test plan

  • npm test --workspace=pmxtjs -- --runInBand tests/filter-markets-local.test.ts
  • npm test --workspace=pmxtjs -- --runInBand
  • npm run build --workspace=pmxtjs
  • git diff --check origin/main...HEAD

Fixes #1524

@Purin1410
Purin1410 force-pushed the codex/fix-1524-null-price-change branch from 5e37ec2 to 057a567 Compare August 12, 2026 07:07
@Purin1410
Purin1410 marked this pull request as ready for review August 12, 2026 07:41
@Purin1410

Copy link
Copy Markdown
Author

Replaced by #2031 after renaming the source branch.

@Purin1410 Purin1410 closed this Aug 12, 2026
@Purin1410
Purin1410 deleted the codex/fix-1524-null-price-change branch August 12, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK drift: filterMarkets/filter_markets handle an explicit null priceChange24h differently — TypeScript's undefined check lets it slip through

1 participant