Skip to content

feat: provide an option to override separator #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opicaud wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: provide an option to override separator #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,7 @@ module.exports = {
generateNotes,
success,
fail,
tagFormat: readPkg.sync().name + '-v${version}',
separator: '-',
tagFormat: mapNextReleaseVersion(versionToGitTag, '${separator}').nextRelease
.version,
};
5 changes: 2 additions & 3 deletions src/version-to-git-tag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
const readPkg = require('read-pkg');

module.exports = async version => {
module.exports = async (version, separator = '-') => {
if (!version) {
return null;
}

const { name } = await readPkg();
return `${name}-v${version}`;
return `${name}${separator}v${version}`;

@JLuzz JLuzz Mar 19, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return `${name}${separator}v${version}`;
return `${name}${separator}${version}`;

};
13 changes: 12 additions & 1 deletion src/version-to-git-tag.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,16 @@ describe('#versionToGitTag', () => {
expect(await versionToGitTag(null)).toBe(null);
done();
});
});
}),
describe('if passed a truly version', () => {
it('returns a correct version', async done => {
expect(await versionToGitTag('1.2.3')).toBe(
'semantic-release-monorepo-v1.2.3'
);
expect(await versionToGitTag('1.2.3', '/')).toBe(
'semantic-release-monorepo/v1.2.3'
);
done();
});
});
});