Repository navigation
feat/shaper helper dedup - #302
Draft
thejustinwalsh wants to merge 2 commits into
Draft
thejustinwalsh wants to merge 2 commits into
thejustinwalsh wants to merge 2 commits into
Conversation
thejustinwalsh
added this pull request to stack #293
October 11, 2026 13:15
Docs report 📚Advisory only — this never blocks merging. Anything left open is tracked in the
✅ attested · After your last source change, update each concept if it is now wrong, then record what you changed and checked:
|
Package performance:
|
| statistic | baseline | candidate |
|---|---|---|
| Median workload p50 | 2.750ms | 3.420ms |
| Workloads ≤1 ms | 1 | 1 |
| Workloads ≤2 ms | 1 | 1 |
| Workloads ≤3 ms | 3 | 1 |
| Workloads >3 ms | 1 | 3 |
Largest candidate workloads (including neutral results):
| workload | baseline | candidate | Δ time |
|---|---|---|---|
| relayout after font-size change | 3.64ms | 4.27ms | +0.630ms |
| publish after color change | 2.83ms | 3.51ms | +0.680ms |
| measure after text change | 2.67ms | 3.33ms | +0.660ms |
| measure 100 unchanged labels | 62.87µs | 66.59µs | +0.004ms |
faster ◀ ┊ ▶ slower Δ p50 p baseline candidate
- measure after text change ┊ ├─●──┤ +24.9% .029 ▃▆█▃▁▁▁▁▁▁ ▁▁▁▁█▆█▂▃▁
- publish after color change ┊ ├───●───┤ +24.2% .029 ▆▇█▄▃▁▁▁▁▁ ▁▁▁█▆▇▄▁▁▂
- relayout after font-size change ┊ ├───●┤ +17.5% .029 ▄█▃▄▃▁▂▂▁▁ ▁▁▁█▄▂▄▂▃▁
measure 100 unchanged labels ├┼──●──┤ +5.9% .114 ▃████▄▃▂▂▃ ▁▃▆▇█▄▃▃▁▂
└──────────────┴──────────────┘
-35% 0 +35%| status | bench | baseline | candidate | Δ time | Δ p50 | p | 95% CI |
|---|---|---|---|---|---|---|---|
| 🔴 slower | measure after text change | 2.67ms | 3.33ms | +0.660ms | +24.9% | .029 | +20.2..+33.4% |
| 🔴 slower | publish after color change | 2.83ms | 3.51ms | +0.680ms | +24.2% | .029 | +13.2..+31.8% |
| 🔴 slower | relayout after font-size change | 3.64ms | 4.27ms | +0.630ms | +17.5% | .029 | +8.6..+20.8% |
1 neutral, 2 skipped
| status | bench | baseline | candidate | Δ time | Δ p50 | p | 95% CI |
|---|---|---|---|---|---|---|---|
| neutral | measure 100 unchanged labels | 62.87µs | 66.59µs | +0.004ms | +5.9% | .114 | -3.3..+14.7% |
| skipped: clock-confounded: slower→neutral · 2.99→3.13 | publish after text change | ||||||
| skipped: clock-confounded: slower→neutral · 3.08→2.95 | reflow after width change |
thejustinwalsh
force-pushed
the
feat/shaper-helper-dedup
branch
2 times, most recently
from
October 16, 2026 15:14
4d52cb5 to
97c516f
Compare
thejustinwalsh
force-pushed
the
feat/shaper-helper-dedup
branch
from
October 18, 2026 16:46
97c516f to
f548581
Compare
thejustinwalsh
force-pushed
the
feat/shaper-helper-dedup
branch
from
October 18, 2026 17:58
f548581 to
eedd695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬