Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the build toolchain from Vite 5 to Vite 7, along with updating the corresponding React plugin and raising the minimum Node.js version requirement.
- Vite upgraded from ^5.4.0 to ^7.3.0 (major version jump)
- @vitejs/plugin-react upgraded from ^4.3.1 to ^5.1.2 (major version jump)
- Node.js engine requirement raised from >=18 to >=20
- npm engine requirement added: >=10
Reviewed changes
Copilot reviewed 157 out of 158 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package-lock.json | Updated Vite to 7.3.0, @vitejs/plugin-react to 5.1.2, raised Node.js requirement to >=20, added npm >=10 requirement, removed nested dependency entries for deprecated packages |
| demos/*/package.json | Updated vite and @vitejs/plugin-react versions across all demo packages to match the new versions |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@copilot ci build failed with 3 failed: can you check in more deaths and understand why, eventually a fix? |
Contributor
* Initial plan * Initial investigation of build failures Co-authored-by: abernier <76580+abernier@users.noreply.github.com> * Fix build failures for CSG and multiple-views demos Co-authored-by: abernier <76580+abernier@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.