Skip to content

Fix DLQ exception chain so all listener failures reach the error topic #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lokendra-egov wants to merge 1 commit into
base: PMIDC-Upgrade-Dev3
Choose a base branch
from
Open

Fix DLQ exception chain so all listener failures reach the error topic #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core-services/egov-indexer/src/main/java/org/egov/infra/indexer/bulkindexer/BulkIndexer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,19 @@ public void indexJsonOntoES(String url, String indexJson, Index index) throws Ex
Object response = restTemplate.postForObject(url.toString(), entity, Map.class);
if (url.contains("_bulk")) {
if (JsonPath.read(mapper.writeValueAsString(response), "$.errors").equals(true)) {
log.info("Indexing FAILED!!!!");
log.info("Response from ES: " + response);
log.error("Indexing FAILED!!!! Response from ES: {}", response);
throw new RuntimeException("ES bulk indexing returned errors for URL: " + url + ", response: " + response);
}
}
} catch (final ResourceAccessException e) {
log.error("ES is DOWN, Pausing kafka listener.......");
indexerUtils.orchestrateListenerOnESHealth();
throw new RuntimeException("ES is DOWN, indexing failed for URL: " + url, e);
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
log.error("Exception while trying to index to ES. Note: ES is not Down.", e);
throw new RuntimeException("Exception while indexing to ES for URL: " + url, e);
}
}

Expand Down
1 change: 1 addition & 0 deletions .../egov-indexer/src/main/java/org/egov/infra/indexer/service/DataTransformationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public String buildJsonForIndex(Index index, String kafkaJson, boolean isBulk, b
result = jsonTobeIndexed.toString();
} catch (Exception e) {
log.error("Error while building jsonstring for indexing", e);
throw new RuntimeException("Failed to build JSON for indexing on index: " + index.getName(), e);
}

return result;
Expand Down
5 changes: 3 additions & 2 deletions core-services/egov-indexer/src/main/java/org/egov/infra/indexer/service/IndexerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ public void validateAndIndex(String finalJson, String url, Index index) throws E
else
indexWithESId(index, finalJson);
} else {
log.error("Indexing will not be done, please modify the data and retry.");
log.error("Object: " + finalJson);
log.error("Indexing will not be done, finalJson is empty. Index: {}", index.getName());
throw new IndexerException("Empty JSON produced for index: " + index.getName() + " - please modify the data and retry",
new RuntimeException("Empty/null JSON for index: " + index.getName()));
}
}

Expand Down