Time stepper schedule - #1748
Open
Yuriyzabegaev wants to merge 39 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
2 times, most recently
from
August 17, 2026 11:55
7e3ed02 to
b14f560
Compare
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
August 17, 2026 11:56
b14f560 to
e787208
Compare
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
August 31, 2026 08:08
77b3f88 to
02cf984
Compare
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
September 3, 2026 11:44
4527945 to
774f55c
Compare
Yuriyzabegaev
marked this pull request as ready for review
September 3, 2026 11:44
Yuriyzabegaev
commented
Sep 3, 2026
Yuriyzabegaev
commented
Sep 3, 2026
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
September 4, 2026 09:31
8d27c90 to
702149b
Compare
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
2 times, most recently
from
September 4, 2026 14:36
19872dd to
8f05797
Compare
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
September 4, 2026 14:39
8f05797 to
fd7e51c
Compare
IvarStefansson
left a comment
IvarStefansson
left a comment
Contributor
There was a problem hiding this comment.
Very good. Do we need a tutorial/update of existing? And remember to add to changelog.md. I guess you can resolve most comments fairly easily. Let me know if and when we need to discuss some of them.
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
September 8, 2026 11:46
b3d6e02 to
2dc2c0c
Compare
keileg
reviewed
Sep 9, 2026
Yuriyzabegaev
force-pushed
the
time-stepper-2
branch
from
September 9, 2026 12:04
ff60756 to
27307eb
Compare
IvarStefansson
approved these changes
Sep 10, 2026
IvarStefansson
left a comment
IvarStefansson
left a comment
Contributor
There was a problem hiding this comment.
Great work on this one, @Yuriyzabegaev! Approving now, feel free to merge if you are confident about resolving comments. Please let me know if you wish to discuss anything.
| raise ValueError("Number of recomputation attempts must be > 0.") | ||
| """ | ||
|
|
||
| self.advanced_schedule: Schedule |
Contributor
There was a problem hiding this comment.
Why is the attribute called advanced_schedule, not simply schedule?
| Returns: | ||
| Next time step if time < final_time. None, otherwise. | ||
| @property | ||
| def schedule(self) -> np.ndarray: |
Contributor
There was a problem hiding this comment.
Since this is not a Schedule, I'm wondering if schedule may not be the best name. Is that related to backwards compatibility?
Co-authored-by: Ivar Stefansson <ivar.stefansson@uib.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR goes after #1732. The new class
TimeScheduleris introduced to replaceTimeManager.Types of changes
What types of changes does this PR introduce to PorePy?
Put an
xin the boxes that apply.Checklist
Put an
xin the boxes that apply or explain briefly why the box is not relevant.pytestwas run with the--run-skippedflag.