Closed
Fix NameError: pp not defined at runtime in _operator_states.py#1709
pp not defined at runtime in _operator_states.py#1709Conversation
… import annotations
Copilot
AI
changed the title
Fix NameError: name 'pp' is not defined in _operator_states.py
Fix NameError: Jun 29, 2026
pp not defined at runtime in _operator_states.py
Copilot created this pull request from a session on behalf of
keileg
June 29, 2026 08:40
View session
Contributor
|
Included directly in #1696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import porepy as ppwas guarded byTYPE_CHECKING, butpp.GridLikeSequenceappeared in__init__annotations of all three mixin classes (TimeDependentOperator,IterativeOperator,ReferenceOperator). Python evaluates these annotations at class definition time, causingNameError: name 'pp' is not definedon everyimport porepy— breaking all tests under Python 3.13.Proposed changes
from __future__ import annotationsto_operator_states.pyto defer annotation evaluation, keepingppsafely behindTYPE_CHECKING.Types of changes
Checklist
pytestwas run with the--run-skippedflag.