-
Notifications
You must be signed in to change notification settings - Fork 1
Add persona-driven bots, wealth economy, and friendship parties #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
807d521
Add deterministic bot personas
pmbstyle 7172c9c
Apply personas to bot dialogue context
pmbstyle 7def15b
Use personas for background party formation
pmbstyle ddc429e
Refine bot persona status and party selection
pmbstyle 3d92346
Merge branch 'main' of https://github.com/pmbstyle/L2Solo
pmbstyle 4f1cc67
Use personas for bot party invitations
pmbstyle e41f0f8
Apply personas to remote bot chat
pmbstyle e4a6449
Let personas choose solo or party simulation
pmbstyle 9982e87
Use wealth personas for market goals
pmbstyle fdeec39
Refine wealth bot sale goals
pmbstyle e6388f1
Add bot friendship and const party roster
pmbstyle 3a1223d
Prioritize friend party invitations
pmbstyle 1f478ef
Improve bot market economy and wealth investments
pmbstyle 651eed1
Prioritize cold shopping transitions
pmbstyle fb527e9
Improve party wait capacity and recruitment fairness
pmbstyle 2004ac5
Fix bot friendship request feedback
pmbstyle 0f44222
Prioritize const friends and support removal
pmbstyle 20805a4
Guard static bots from friend recruitment
pmbstyle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the dead
sociabilitybranch inrestCloser.The
trait(session, 'sociability') >= 0.70branch on Line 40 returns the same string as the default branch on Line 41. This branch can never produce a different result than omitting it, unlikerestOpenerandroleLine, which each vary text per trait or drive.Give the sociability branch distinct text, consistent with the drive/trait-based variety used elsewhere in this file.
🐛 Proposed fix
function restCloser(session) { if (trait(session, 'caution') >= 0.70) return 'Sounds good. We can keep it steady and avoid rushing back in.'; - if (trait(session, 'sociability') >= 0.70) return 'Sounds good. Better than rushing back in alone.'; + if (trait(session, 'sociability') >= 0.70) return 'Sounds good. It is better with company than rushing back in alone.'; return 'Sounds good. Better than rushing back in alone.'; }📝 Committable suggestion
🤖 Prompt for AI Agents