Make cold bot progression target real fights - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cold bots now pursue the actual monsters needed for their equipment goals. Their combat uses real character stats, skills, gear effects, and the defeated monster's own drop table. Nearby aggressive monsters can still interrupt a targeted hunt, so farming remains a real encounter rather than a scripted kill.
Parties now preserve shared combat outcomes correctly: each member keeps personal progress, while the population view records the encounter once. Party creation is safely queued behind the cold scheduler so aligned timers cannot silently prevent new parties from forming.
Why
Previously a party result could be overwritten by an earlier state snapshot, losing its target and making the group appear to fight unrelated monsters. The party-formation timer could also collide with the scheduler on every interval and never run.
Validation
pm test)