docs: align README examples and clean up string validation in SimpleKeyLock#28
Conversation
- Added `.createDatabase(true)` to `JDBCKeyLockBuilder` in the main README's "Programmatic Usage" example to ensure accurate setup instructions aligned with sub-module documentation. - Refactored `SimpleKeyLock.java` to use `String.isBlank()` instead of `trim().isEmpty()` for cleaner, standard string validation in Java. Co-authored-by: pmalirz <19637300+pmalirz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the request to improve overall clean code practices while perfectly aligning the README documentation with existing codebase capabilities.
Changes include:
.createDatabase(true)to the programmatic use case example inREADME.md, perfectly aligning it with what's documented in thedlock-jdbcsub-module and the required initial setup to avoid database errors.SimpleKeyLock.tryLockto adopt standard Java conventions by using.isBlank()instead of.trim().isEmpty().Tests pass completely with no regressions.
PR created automatically by Jules for task 18385575067657375025 started by @pmalirz