Align Javadocs and READMEs with actual code constraints#27
Conversation
- Added `lockKey` and `expirationSeconds` constraints and `@throws IllegalArgumentException` to the default `tryLock` methods in `KeyLock.java`. - Fixed typo in `unlock` Javadoc in `KeyLock.java`. - Updated `dlock-api/README.md` `KeyLock` code snippet to match actual code and updated Javadocs. - Added Javadocs to `@Lock` annotation parameters referencing `MAX_LOCK_KEY_LENGTH` and explaining the `expirationSeconds` > 0 constraint. - Updated `dlock-jdbc/README.md` to reflect that PostgreSQL uses `ON CONFLICT DO NOTHING` for inserting duplicate locks rather than just conditional INSERTs used by H2 and Oracle. Co-authored-by: pmalirz <19637300+pmalirz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This submission updates the Javadocs and READMEs across the repository to ensure they accurately reflect the current code constraints, specifically the parameters
lockKeyandexpirationSeconds, and aligns thedlock-jdbcREADME with theON CONFLICT DO NOTHINGapproach used for PostgreSQL.PR created automatically by Jules for task 1021213461243690294 started by @pmalirz