Enforce API guidelines in SimpleKeyLock and align dlock-api README#24
Enforce API guidelines in SimpleKeyLock and align dlock-api README#24pmalirz wants to merge 1 commit into
Conversation
- Implemented input validation in `SimpleKeyLock.tryLock()` to ensure `lockKey` is non-blank and <= 1000 characters, and `expirationSeconds` > 0. - Added null safety check in `SimpleKeyLock.unlock()` to prevent NPEs. - Added test coverage in `LocalKeyLockTest` to verify parameter validation. - Updated `dlock-api/README.md` to perfectly align with the existing `KeyLock` interface's javadocs and semantics for auto-release methods. Co-authored-by: pmalirz <19637300+pmalirz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Enforces the API guidelines listed in the root
README.mdwithinSimpleKeyLockusing fail-fastIllegalArgumentExceptionchecks. Adds null-safety tounlock. Alignsdlock-api/README.mdwith the current code.PR created automatically by Jules for task 7092715494353643568 started by @pmalirz