document DeploymentSettings and AgentConfiguration singleton setup#610
document DeploymentSettings and AgentConfiguration singleton setup#610zreigz wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
✅ Deploy preview for docs-pr-610 is ready!
| Name | Details |
|---|---|
| ⚡ Service | docs-pr-610 (5 / 5 ready) |
| ☁️ Cluster | plural (eks) |
| 52872e3 | |
| https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... | |
| 🔍 Logs URL | https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... |
| 🌊 Flow URL | https://console.mgmt.plural.sh/flows/08a17af1-8578-449e-9ae1-28ccd97eafc... |
| Preview Link | Preview |
You can learn more about preview environments and Plural Flows here
Greptile SummaryThis PR restructures the Continuous Deployment section by splitting the single
Confidence Score: 4/5Safe to merge; the documentation content is accurate and the sandboxing.md bug fix is correct. The routes.json conflict is cosmetic and unlikely to affect real users at runtime. The documentation content is accurate and the sandboxing.md bug fix is correct. The two issues found are non-blocking: a dead route entry in routes.json and a potentially misleading '0s' duration in the full example. generated/routes.json (dead route entry at line 554) and pages/plural-features/continuous-deployment/deployment-operator/agent-configuration.md (full example with pipelineGateInterval: '0s')
|
| Filename | Overview |
|---|---|
| pages/plural-features/continuous-deployment/deployment-operator/agent-configuration.md | New page documenting the AgentConfiguration CRD; well-structured, but the full example disables pipeline gate evaluation by setting pipelineGateInterval to "0s" |
| pages/plural-features/continuous-deployment/management-controller/deployment-settings.md | New page documenting the DeploymentSettings CRD; singleton name/namespace requirements, spec reference, and verification steps are all clear and accurate |
| generated/routes.json | Adds routes for new pages, but includes a route for /deployment-operator/deployment-settings that conflicts with a permanent redirect defined for the same path in docs-structure.ts |
| pages/getting-started/advanced-config/sandboxing.md | Fixes the AgentConfiguration example: corrects name from "global" to "default" and removes the invalid namespace (resource is cluster-scoped) |
| pages/plural-features/continuous-deployment/deployment-operator/index.md | New index page for the deployment-operator section, replacing the deleted flat file; links and cross-references are accurate |
| pages/plural-features/continuous-deployment/management-controller/index.md | New index page for the management-controller section; clear overview with correct cross-links to DeploymentSettings and reconciliation logic docs |
| src/routing/docs-structure.ts | Adds new sections to the nav tree and a permanent redirect for /deployment-operator/deployment-settings; the redirect source matches a stale route entry in routes.json |
Reviews (1): Last reviewed commit: "ensure DeploymentSettings and AgentConfi..." | Re-trigger Greptile
Deniwn22
left a comment
There was a problem hiding this comment.
Logic looks correct. One suggestion: the early return on line prevents the cleanup function from running — worth adding a finally block.
Plural Flow: docs
Plural Preview: docs