Add NGINX Ingress Controller compatibility#3711
Conversation
Greptile SummaryThis PR introduces F5 NGINX Ingress Controller (distinct from the community
Confidence Score: 5/5Safe to merge; this is a data-and-scraper addition with no changes to shared infrastructure. All changes are additive: a new per-app YAML, a single manifest entry, aggregate data, and a new scraper that correctly wires into the existing merge/reduce pipeline. The scraper was manually verified by the author and the static data is consistent across all three files. No files require special attention.
|
| Filename | Overview |
|---|---|
| utils/compatibility/scrapers/nginx-ingress-controller.py | New scraper for the F5 NGINX Ingress Controller; correctly wires into the shared update_versions_data / reduce_versions pipeline to preserve existing summaries, but _default_image makes two uncached HTTP requests per table row rather than using the @lru_cache-wrapped fetch_page. |
| static/compatibilities/nginx-ingress-controller.yaml | New per-app compatibility file with 11 versions (3.4.3–5.5.0); icon URL is pinned to the v5.5.0 release tag (pre-existing thread note). |
| static/compatibilities/manifest.yaml | Adds nginx-ingress-controller between ingress-nginx and istio; ordering and formatting are consistent with the rest of the file. |
| static/compatibilities.yaml | Aggregate file updated to include the new nginx-ingress-controller block; data is consistent with the per-app YAML and correctly placed between ingress-nginx and istio. |
Reviews (2): Last reviewed commit: "Preserve NGINX Ingress Controller scrape..." | Re-trigger Greptile
| @@ -0,0 +1,83 @@ | |||
| icon: https://raw.githubusercontent.com/nginx/kubernetes-ingress/v5.5.0/charts/nginx-ingress/chart-icon.png | |||
There was a problem hiding this comment.
Icon URL pinned to a specific release tag
icon: https://raw.githubusercontent.com/nginx/kubernetes-ingress/v5.5.0/charts/nginx-ingress/chart-icon.png hard-codes v5.5.0. The scraper only updates versions and does not touch the icon field, so as new releases land the icon will remain pinned to this tag indefinitely. Consider using the main branch path, consistent with how some other per-app YAMLs reference icons.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@greptileai review |
2bf2b3f to
efb9df9
Compare
Summary
Sources:
Test Plan
Test environment: not deployed; compatibility data-only change.
python -m py_compile utils/compatibility/scrapers/nginx-ingress-controller.py.git diff --check.Checklist