Skip to content

Add diagnostics #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mernst wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add diagnostics #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce2adfe
Add diagnostics
mernst May 20, 2026
02ac4f8
Enable debugging
mernst May 20, 2026
1c063c2
Use `git-changes` instead of `ci-info`
mernst May 25, 2026
f08b5ab
Merge ../git-scripts into ci
mernst May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ jobs:
uses: actions/setup-python@v6
with:
python-version: '3.14.5'
- name: git-changes
run: |
mkdir -p /tmp
git -C /tmp clone --depth=1 -q https://github.com/plume-lib/plume-scripts.git
/tmp/plume-scripts/git-changes --debug
Comment on lines +18 to +22

@coderabbitai coderabbitai Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Keep the diagnostics checkout out of /tmp/plume-scripts.

git-clone-related checks /tmp/plume-scripts first (git-clone-related, Lines 114-118), so this step changes what later tests exercise—they now reuse the preseeded checkout instead of covering the script's own bootstrap path.

Proposed fix 
       - name: git-changes
         run: |
           mkdir -p /tmp
-          git -C /tmp clone --depth=1 -q https://github.com/plume-lib/plume-scripts.git
-          /tmp/plume-scripts/git-changes --debug
+          git -C /tmp clone --depth=1 -q https://github.com/plume-lib/plume-scripts.git plume-scripts-diagnostics
+          /tmp/plume-scripts-diagnostics/git-changes --debug
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/test.yml around lines 18 - 22, The workflow step named
"git-changes" is cloning plume-scripts into the fixed path /tmp/plume-scripts
which pollutes git-clone-related's expected lookup and causes later tests to
reuse that preseeded checkout; modify the "git-changes" step to clone into a
unique or temporary directory (e.g., use mktemp -d or include a random suffix)
and invoke the script from that directory (the invocation currently using
/tmp/plume-scripts/git-changes should be updated to the new path) so that
git-clone-related still exercises the script's bootstrap path.

- name: Run tests
run: |
git config --global user.email "example@example.com"
Expand Down
3 changes: 3 additions & 0 deletions git-clone-related
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ if [ "$1" = "--debug" ]; then
set -x
fi

# TEMPORARY
DEBUG=1
Comment on lines +50 to +51

@coderabbitai coderabbitai Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Remove the temporary default DEBUG=1 before merge.

This makes the diagnostic path opt-out instead of opt-in and also forces the extra ci-org-and-branch --debug invocation below on every normal run.

Proposed fix 
-# TEMPORARY
-DEBUG=1
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# TEMPORARY
DEBUG=1
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@git-clone-related` around lines 50 - 51, Remove the temporary default setting
that forces diagnostics on by deleting the DEBUG=1 line in the git-clone-related
file so the diagnostic path remains opt-in; ensure any code that relies on debug
mode uses explicit flags or environment checks (e.g., the existing
ci-org-and-branch --debug invocation) rather than a hardcoded default and
confirm no other places set DEBUG=1 implicitly.


# FALLBACK_BRANCH may be unset.
if [ "$1" = "--upstream-branch" ]; then
shift
Expand Down
Loading