Migrate to b8 framework v1.0 + namespace rename (release 2.4.0) - #281
Open
sultann wants to merge 1 commit into
Open
Migrate to b8 framework v1.0 + namespace rename (release 2.4.0)#281sultann wants to merge 1 commit into
sultann wants to merge 1 commit into
Conversation
…antities, bump to 2.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings min-max (free) onto the current b8 framework (
byteever/pluginv1.0) and the wc-starter blueprint, renaming the namespace toPluginEver\MinMaxQuantities. Framework swap only — no feature changes. Ships as 2.4.0 on top of the 2.3.0 release.Changes
byteever/plugin: ^1.0, dropbytekit-settings(absorbed into the framework), Strauss prefixes updated, removed thebytekit-textdomainperl hack.WooCommerceMinMaxQuantities→PluginEver\MinMaxQuantities, with aclass_aliasBC block (Plugin,Cart,Admin\Settings) for the pre-b8 names — deprecated, removable in a few releases.Plugin.php→$components+ boot onwoocommerce_loaded;Cart/Installer/Admin\*→B8\Component.B8\SettingsUIsubclass — fields ported verbatim, everywcmmq_*option key preserved, WooCommerce storage kept viarender_fields/save_fields; addedAdmin\Menu(submenu registrar).bk-/bytekit-→b8-; build switched from@byteever/scripts/webpack to a minimal esbuild build (single SCSS).Verified
composer update→byteever/plugin1.0.0, Strauss-prefixed.phpcs(ByteEver-Default) clean;php -lclean across all PHP.npm run build(esbuild) producesassets/build/css/admin.css.Needs manual verification before merge
wcmmq_*options (data continuity).Flagged (pre-existing, faithful port — intentionally not changed)
Cart::output_errors:unset( $notice[ $i ] )targets the wrong array (likely a no-op).Cart::add_to_cart_validation:(int) WC()->cart->get_cart_total() > (int) wc_price(...)comparison looks wrong.Cart::check_cart_items: float modulo(float) $quantity % (float) $step.The Pro sibling (
wc-min-max-quantities-pro→ v1.3.0) migration is the follow-up, not in this PR.