Say which path takes the app down - #35
Merged
Merged
Conversation
Two Windows runs have now been caught with the same ending: the process exits with code 0, so the app quits itself rather than crashing. Two places call app.quit(), the single instance lock and window-all-closed, and from the outside they look the same. Each of them says so now, and every window says when it is created and closed. In dev that lands in the terminal; on CI it lands in the log the e2e fixture keeps beside the traces. The splash error in the first capture was not the cause: the second capture does not have it and ends the same way.
01-persistence launches its own app rather than taking the fixture's, and its launches race the worker's app for the single instance lock. That is where the answer is most likely to be, and it was the one place the log did not reach. Both apps write to the same file, so every line carries the process id that produced it.
The capture moved the question. Neither quit path fired, and the app did not crash: the main window closed 0.58 seconds after it was created, and the process only ended later when the run gave up on it. Nothing in this code closes that window, so the ways it can go by itself are the renderer dying, the page failing to load, or the window going unresponsive. Each says so now, with the reason Electron gives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Windows failures have now been captured, both ending the same way:
Code 0 means the app quit itself. Two places do that, and they are indistinguishable from outside the process: the single instance lock in
index.ts, andwindow-all-closed. Each says so now, and every window reports when it is created and when it closes.The first capture also carried
ERR_FAILEDloading the splash, from a load that was stopped rather than a file that was missing. That looked like the cause until the second capture arrived without it and ended identically. It stays out of this change.Why the lines are not gated on the e2e run
The same question comes back as "the app closed by itself" from a user, and the answer is as unavailable there as it was here. In dev the lines land in the terminal, in a packaged app they go where a packaged app's stdio goes, and on CI the fixture keeps them.
Draft until a Windows run drops the process again and the log names the path.