Update a11y guidelines - #6361
Conversation
✅ Deploy Preview for plone-components canceled.
|
|
@Wagner3UB @JeffersonBledsoe @ichim-david would y'all please submit a PR review? Thank you! |
|
@stevepiercy looks good, it will have to wait for the merge of the tests done at Salamina sprint in order to create the core/a11y folder. This way your statement on where to place tests is valid. |
|
@ichim-david @sneridagh @Wagner3UB @JeffersonBledsoe is the blocker complete, so we can merge this? |
|
Hi There! 👋 We haven't seen any activity on this pull request in a while 😴, and we want to make sure that it's still relevant. Please let us know by:
Otherwise close this pull request. 🧹 |
thet
left a comment
There was a problem hiding this comment.
LGTM. Also the test location for a11y tests is in the meantime on the right place.
|
@stevepiercy I rebased this PR on the current main branch. IMO it's good to merge. |
|
re-ping @ichim-david @sneridagh @Wagner3UB @JeffersonBledsoe @pnicolli for final review. |
Wagner3UB
left a comment
There was a problem hiding this comment.
@stevepiercy These are my suggestions, just some simple ones to start with. We could talk all day about a11y best practices, but I think these are a great first step. Feel free to adapt or condense the content as you see fit.
Thank you for the collaboration, this is a huge step forward!
|
@Wagner3UB sorry for the long delay. I've added your suggestions, but reformatted the items into definition lists, as those made more sense semantically than a subsection heading. Please let me know. Thank you! |
|
@stevepiercy Don’t worry about the time, you did a fantastic job. Thank you! There’s just one small piece that may have slipped through unnoticed. Other than that, everything looks good to me. I’ll keep this file on my end and add it to the accessibility meeting notes. I think we can make it even better going forward. |
|
@stevepiercy LGTM, and thank you again |
@plone/volto-accessibility please review.
📚 Documentation preview 📚: https://volto--6361.org.readthedocs.build/
Docs review/ updates to make