Skip to content

display style schema as accordion not tabs - #3444

Closed
danielamormocea wants to merge 13 commits into
mainfrom
accordions
Closed

display style schema as accordion not tabs#3444
danielamormocea wants to merge 13 commits into
mainfrom
accordions

Conversation

@danielamormocea

Copy link
Copy Markdown
Contributor

related to #3414

Screenshot 2022-06-20 at 17-27-22 Edit Page

@netlify

netlify Bot commented Jun 20, 2022

Copy link
Copy Markdown

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit e80f5ca
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/63fe15bf93f9c40008b013eb

@cypress

cypress Bot commented Jun 20, 2022

Copy link
Copy Markdown

Passing run #4104 ↗︎

0 459 20 0 Flakiness 0

Details:

Merge branch 'master' into accordions
Project: Volto Commit: e80f5ca753
Status: Passed Duration: 09:24 💡
Started: Feb 28, 2023 2:58 PM Ended: Feb 28, 2023 3:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@danielamormocea

Copy link
Copy Markdown
Contributor Author

Screenshot 2022-06-23 at 18-39-09 Edit Page

Screenshot 2022-06-23 at 18-38-47 Edit Page

I added a boolean option named "stylesSchemaTabsView" which can be passed to the Blocks. If it is true, we can have the Styling with tabs, and if it is false, then we have the accordions.

I also talked with Madalina for a view on the UI situation, and she recommended to have the 'Styling' header just like the Block's name header, so it is cleaner and consistent. Also, in the accordions' case, we always have the 'Default' open when we first open the edit view sidebar, and there is just one accordion open at all times, so when we click on "Other" the "Default" closes.

@tiberiuichim

Copy link
Copy Markdown
Contributor

This would be a nice addition to the ObjectWidget, but it needs to be framed as an ObjectWidget configuration option, rather then something related to the schema.

@tiberiuichim tiberiuichim added this to the 17.x.x milestone Nov 25, 2022
@sneridagh sneridagh modified the milestones: 17.x.x, 18.x.x Sep 26, 2023
@sneridagh sneridagh modified the milestones: 18.x.x, 19.x.x May 21, 2024
@nileshgulia1

Copy link
Copy Markdown
Member

I see its targeted for 19.x. It's a nice feature to have. As Daniela is not working with us, I will assign it myself for the moment.

@nileshgulia1 nileshgulia1 self-assigned this Sep 24, 2024
@pnicolli

Copy link
Copy Markdown
Contributor

@nileshgulia1 did you get any chance to go back to this? It doesn't look like breaking change but we are getting closer to a Volto 19 release and wanted to confirm.

@nileshgulia1

Copy link
Copy Markdown
Member

@pnicolli This has become outdated. I have to resurrect it. I will look at the conflicts and will update you with the current state of the PR.

@sneridagh

Copy link
Copy Markdown
Member

@nileshgulia1 please close this PR and create another one from the changes (copying code). To make sure the injection attempt with the forcepush is gone. Thanks.

@nileshgulia1

Copy link
Copy Markdown
Member

Sure, Victor. Thank you.

@fredvd

fredvd commented Jan 19, 2026

Copy link
Copy Markdown
Member

I have removed the referenced user who made the injection attempt from the Plone organisation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants