You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added a boolean option named "stylesSchemaTabsView" which can be passed to the Blocks. If it is true, we can have the Styling with tabs, and if it is false, then we have the accordions.
I also talked with Madalina for a view on the UI situation, and she recommended to have the 'Styling' header just like the Block's name header, so it is cleaner and consistent. Also, in the accordions' case, we always have the 'Default' open when we first open the edit view sidebar, and there is just one accordion open at all times, so when we click on "Other" the "Default" closes.
This would be a nice addition to the ObjectWidget, but it needs to be framed as an ObjectWidget configuration option, rather then something related to the schema.
@nileshgulia1 did you get any chance to go back to this? It doesn't look like breaking change but we are getting closer to a Volto 19 release and wanted to confirm.
@nileshgulia1 please close this PR and create another one from the changes (copying code). To make sure the injection attempt with the forcepush is gone. Thanks.
I have removed the referenced user who made the injection attempt from the Plone organisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #3414