Skip to content

Fix expected test output due to new plone.app.discussion profile - #2043

Merged
mauritsvanrees merged 1 commit into
mainfrom
maurits-fix-uncommitted-doc-change
Aug 27, 2026
Merged

Fix expected test output due to new plone.app.discussion profile#2043
mauritsvanrees merged 1 commit into
mainfrom
maurits-fix-uncommitted-doc-change

Conversation

@mauritsvanrees

Copy link
Copy Markdown
Member

An action run on the main branch currently fails.
See https://github.com/plone/plone.restapi/actions/runs/33066530077/job/98497855546

@mister-roboto

Copy link
Copy Markdown

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees

Copy link
Copy Markdown
Member Author

The important check now succeeds:
https://github.com/plone/plone.restapi/actions/runs/33067211635/job/98500159067?pr=2043
I merge.

@mauritsvanrees
mauritsvanrees merged commit 497d7e9 into main Aug 27, 2026
15 of 20 checks passed
@mauritsvanrees
mauritsvanrees deleted the maurits-fix-uncommitted-doc-change branch August 27, 2026 11:50
@davisagli

Copy link
Copy Markdown
Member

@mauritsvanrees Thank you.

I should probably change https://github.com/plone/plone.restapi/blob/main/constraints.txt to pin a specific version instead of 6.2-dev so we don't get surprise failures like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants