Skip to content

faster uploads by avoiding unneed large blob reads - #166

Merged
jensens merged 5 commits into
masterfrom
fast_uploads
Apr 2, 2025
Merged

faster uploads by avoiding unneed large blob reads#166
jensens merged 5 commits into
masterfrom
fast_uploads

Conversation

@djay

@djay djay commented Nov 26, 2024

Copy link
Copy Markdown
Member

replaces #155

fixed #167

As mentioned in the comments perhaps a better long term fix is to change zope.schema to avoid accessing properies if they are decorators and instead using something like - https://stackoverflow.com/questions/16169948/check-if-something-is-an-attribute-or-decorator-in-python first

@mister-roboto

Copy link
Copy Markdown

@djay thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@djay

djay commented Nov 26, 2024

Copy link
Copy Markdown
Member Author

I created a ticket for zope.schema suggestion. zopefoundation/zope.schema#127

@djay

djay commented Dec 2, 2024

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@djay
djay requested a review from davisagli February 21, 2025 07:44
@djay djay self-assigned this Feb 24, 2025
@jensens
jensens merged commit 4287b72 into master Apr 2, 2025
@jensens
jensens deleted the fast_uploads branch April 2, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

imports/uploads slow due to reading files into memory due to schema validation and exif (for images)

3 participants