Skip to content

Searchabletext indexer fix - #113

Merged
mauritsvanrees merged 5 commits into
masterfrom
searchabletext-indexer-fix
Mar 26, 2026
Merged

Searchabletext indexer fix#113
mauritsvanrees merged 5 commits into
masterfrom
searchabletext-indexer-fix

Conversation

@petschki

@petschki petschki commented Mar 18, 2026

Copy link
Copy Markdown
Member
  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

remove SearchableText indexer and use IDynamicTextIndexExtender only. See #112 for discussion.

@petschki
petschki requested a review from mauritsvanrees March 18, 2026 14:40
@petschki
petschki force-pushed the searchabletext-indexer-fix branch from 86b3322 to 5eafe26 Compare March 19, 2026 07:30
@petschki

Copy link
Copy Markdown
Member Author

@mauritsvanrees I've updated mosaic to enable the behavior for the types. see plone/plone.app.mosaic#687

@mauritsvanrees mauritsvanrees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works for me.

Comment on lines 76 to 77
# install plone.app.contenttypes on Plone 5
self.applyProfile(portal, "plone.app.contenttypes:default")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying the plone.app.contenttypes profile is not needed anymore. Same for the other lines that load plone.app.contenttypes.
But that is unrelated to this issue. Just noting it.

@mauritsvanrees
mauritsvanrees merged commit 7f1e2d1 into master Mar 26, 2026
9 checks passed
@mauritsvanrees
mauritsvanrees deleted the searchabletext-indexer-fix branch March 26, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants