Conversation
The healthcheck fetched the site root, coupling container health to backend availability and the Plone Site view permission. Point it at Volto's /ok liveness route, which is served by the frontend and does not proxy to the backend. Also wrap the corepack install in a heredoc RUN for consistency with the busybox block above. Closes #78
davisagli
approved these changes
Jul 8, 2026
| RUN <<EOT | ||
| set -e | ||
| npm i -g corepack@latest && corepack enable | ||
| EOT |
Member
There was a problem hiding this comment.
I don't see the point of this change when it is a one-line command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the production healthcheck in
pnpm/Dockerfile.prodat Volto's/okliveness route instead of the site root.Why
The healthcheck previously fetched
/, which renders the Plone Site root. That coupled the container's health to backend state and permissions rather than to the frontend process itself. The check reported unhealthy whenever:/).In both cases the Volto/Express process was running fine, yet the container was marked unhealthy — causing false failures and unwanted orchestrator restarts.
/okis served directly by the frontend and returns200 OKwithout proxying to the backend, so the healthcheck now reflects the actual state of the frontend process.Changes
http://127.0.0.1:$LISTEN_PORT/ok.corepackinstall in a heredocRUNfor consistency with the busybox block above (no functional change).Closes #78