Repository navigation
Conversation
Each -demo image is the official plone image for the series (4.3.19, 5.0.8, 5.1.6, 5.2.14), pinned by digest, plus a database with a Plone site already created at /Plone. The bases are not rebuilt: their Debian releases have left deb.debian.org. demo/seed.sh starts the official image on the host, creates the site through legacy/shared/create-plone-site.sh, stops Zope with the signal that closes the storage cleanly (INT for 5.2, TERM for the others) and copies the database out. demo/Dockerfile bakes it at /app/seed, and a wrapper entrypoint copies it into /data on first start before handing over to the base image's entrypoint. The demo build workflow tests every series and publishes <series>-demo and <full>-demo to plone/plone and GHCR from main. Shared legacy scripts: - create-plone-site.sh checks the Barceloneta theme on Plone 5, where the Plone 4 skin check reads nothing. - smoke-test.sh can read product-load errors from docker logs, for 5.2, which writes no log file. - The JSON gate passed on 5.2 without the probe running: the probe was Python 2 only, and the gate matched the marker inside the traceback that quoted the probe's source. The probe now runs on Python 2.3 - 3.8, and the gate only accepts the marker at the start of a line. Refs #211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
-demovariants for the 4.3, 5.0, 5.1 and 5.2 series. Each one is the officialploneimage for its series (4.3.19, 5.0.8, 5.1.6, 5.2.14), pinned by digest, plus a database with a Plone site already created at/Plone. The base images are not rebuilt (see #213).How it works (
demo/):curl, and nothing can be installed into them, soseed.shcreates the site from the host. It starts the official image, runslegacy/shared/create-plone-site.sh, stops Zope, checks that the storage was closed cleanly, and copiesData.fsand the blobs out withdocker cp.Dockerfileadds that seed at/app/seed, plus a wrapper entrypoint. On first start the wrapper copies the seed into/data, then runs the base image's own entrypoint. When/dataalready holds a database, nothing is copied.demo buildworkflow seeds, builds and smoke-tests all four series. Onmainit pushes<series>-demoand<full>-demotoplone/ploneand GHCR, like the legacy workflow.What differs between the base images: 5.2 only stops cleanly on SIGINT. With SIGTERM,
docker stopran into its 120s timeout and killed Zope. 5.2 also logs to stdout/stderr instead of/data/log/.Changes to the shared legacy scripts. These make the legacy CI rebuild all 11 series on this PR:
create-plone-site.sh: on Plone 5, the theme check now looks for++theme++barcelonetain the rendered page. The skin check used for Plone 4 found nothing on Plone 5.smoke-test.sh: newSMOKE_LOG_SOURCE=dockeroption, which reads product-load errors fromdocker logs.Tested locally:
-demoimages pass the smoke test: the site is already there on first start,admin:adminauthenticates, and the product-load and JSON checks pass.After merge: add the demo subsections for 4.3, 5.0, 5.1 and 5.2 to
plone/documentation'sdocs/install/containers/images/historical.md(plone/documentation#2103).Refs #211