Repository navigation
Expand the legacy series-wiring checklist from four places to eight - #204
Merged
Merged
Conversation
The "keep four places in sync" sentence undercounted the work. It named the directory, the matrix table, the Makefile and the workflow, but omitted the version's own README, the root README's image table, the CHANGES.md entry, and the matrix table's "remaining N" count -- and it collapsed the workflow's paths-filter and its ALL list into one item, though they are separate edits with different consequences. Seven series have now been ported against that sentence, and each one had to recover the real list from the previous port's diff rather than from the document meant to carry it. The failure mode is worth naming, so the new text does: missing an entry does not break the build. A forgotten ALL entry means the image is simply never built on main; a forgotten table row means the docs disagree with what ships. Both are silent. Also records the verification steps that follow the edits -- make lint, make -n on the four targets for the new series, and both smoke gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
legacy/README.mdtold contributors to "keep four places in sync" when adding a series. That undercounted it.The sentence named the directory, the matrix table, the Makefile and the workflow — and omitted:
README.md(its validated/hypothesised ledger)README.mdCHANGES.mdentryIt also collapsed the workflow's paths-filter entry and its
ALLlist into a single item, though they are separate edits in different parts of the file, with different consequences.Why it matters
Missing an entry does not break the build, which is exactly why the list needs to be right:
ALLentrymain— CI stays greenAll three are silent. Nothing turns red.
Evidence
Seven series have now been ported against that sentence (#180, #182, #183, #184, #185, #186, #187). Each port recovered the real list from the previous port's commit diff rather than from the document meant to carry it — which works, but only because there was always a previous port to copy from.
The change
The sentence becomes a numbered list of the eight places, with the two workflow edits split apart and the silent-failure mode named. It also records the verification steps that follow:
make lint,make -non all four targets for the new series (the GNU Make 3.81 stem trap), and both smoke gates —SMOKE_CREATE_SITE=1 make test-<version>andmake test-demo-<version>.Docs only — no Dockerfile, Makefile or workflow changes. Four series remain to be ported (#194, #195, #196, #197), all copy-and-wire, so this lands before they do.