Fix Image add Content tab crash and the form close control. - #164
Open
aryan7081 wants to merge 4 commits into
Open
Fix Image add Content tab crash and the form close control.#164aryan7081 wants to merge 4 commits into
aryan7081 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
This issue happened because the Image add Content tab spread the full JSON Schema onto React Aria widgets, so object fields crashed the route. The image object browser then fetched
/@objectBrowserWidget/@@add, which is a CMS route rather than a content path, so React Router had no result for that resource. Close did nothing on add because it linked tocontent['@id'], which a new item does not have yet. Save then failed because the Image field stored a URL string whilecreateContentexpects a NamedBlobImage object (data,encoding,content-type,filename).This fix registers ImageWidget for REST API Image and file fields, forwards only a small set of widget props, maps
/@@addand/@@editto a real content path before loading the object browser, and points Close at that path (or the item@idon edit). Uploads write a NamedBlobImage payload; picking an existing image copies that file into the same shape so Save can succeed. Image scale flattening also skips missingscales/downloadso blob images do not take down the view.Caution
The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #