Skip to content

feat: send withdrawal data unprocessed#1256

Open
N-Feist wants to merge 4 commits into
stablefrom
test/send-data-unprocessed
Open

feat: send withdrawal data unprocessed#1256
N-Feist wants to merge 4 commits into
stablefrom
test/send-data-unprocessed

Conversation

@N-Feist

@N-Feist N-Feist commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

AB#197312

All changes meet the following requirements

  • Changelog entry was added
  • Changes have been documented
  • Changes have been tested by the author
  • Changes have been tested by the reviewer
  • Changes to routes were replicated in webshop package
  • Plugin can be built

@plentymarkets/plentyshop

@N-Feist N-Feist marked this pull request as ready for review July 1, 2026 11:31
@N-Feist N-Feist requested a review from a team as a code owner July 1, 2026 11:31
@N-Feist N-Feist requested a review from Copilot July 1, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the io/cancellation API endpoint to forward the incoming cancellation/withdrawal payload to CancellationRepositoryContract::submitCancellationRequest() largely unmodified (while still injecting lang), and to return the repository’s response body.

Changes:

  • Stop mapping/validating individual form fields and instead forward the full request payload to submitCancellationRequest().
  • Return the repository response as the API response body.
  • Add structured error responses for StorefrontException and a generic \Throwable catch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Api/Resources/CancellationResource.php Outdated
Comment thread src/Api/Resources/CancellationResource.php Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread src/Api/Resources/CancellationResource.php
Comment thread src/Api/Resources/CancellationResource.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants