This repository was archived by the owner on Apr 28, 2022. It is now read-only.
[FIX] - Readonly / Required - #88
Closed
richard-willdooit wants to merge 2 commits into
Closed
Conversation
richard-willdooit
changed the title
Contributor
|
@richard-willdooit the tests have stopped for some reason on all PR's. I'm not sure exactly what the cause is but I need to get it fixed before merging onto the stable branches. |
richard-willdooit
force-pushed
the
10.0-readonly-on-multi-depends
branch
from
May 4, 2017 00:29
3eb9abc to
992e215
Compare
Dynamic readonly / required on pop-ups need to assume that if they are based on different domain records then they are "or" insted of "and".
richard-willdooit
force-pushed
the
10.0-readonly-on-multi-depends
branch
from
May 5, 2017 01:43
992e215 to
1e3a421
Compare
Codecov Report
@@ Coverage Diff @@
## 10.0 #88 +/- ##
==========================================
- Coverage 61.11% 60.62% -0.49%
==========================================
Files 14 14
Lines 1368 1379 +11
==========================================
Hits 836 836
- Misses 532 543 +11
Continue to review full report at Codecov.
|
Contributor
Author
|
@PCatinean If you think this is more important than the other fix #97 then I will look at the tests, but I would like to get #97 merged before I write more tests in areas which will have conflicts. |
Contributor
Author
|
Again, #104 deals with this more logically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic readonly / required on pop-ups need to assume that
if they are based on different domain records then they are "or"
instead of "and".