Fix and feat - #133
Open
T1anjiu wants to merge 3 commits into
Open
Conversation
- Remove MD5/SHA1, use SHA256/SHA512 only - Fix file handle leaks in upload and zipRPC - Enhance error logging and path validation - Add directory existence check on startup"
pldubouilh
reviewed
Apr 24, 2026
Comment on lines
-254
to
257
| case "md5": | ||
| hash = md5.New() | ||
| case "sha1": | ||
| hash = sha1.New() | ||
| case "sha256": |
Owner
There was a problem hiding this comment.
Can you keep md5 and sha1 ? It's cryptographically insecure, but still widely used by other systems for file stamping.
Owner
|
Thank you for your PR ! I'm ready to accept it - just please bring back md5 and sha1, I know it's used by some users. |
Author
Done. I've restored MD5 and SHA1 as suggested. |
Owner
|
Thank you ! I'll test it out a bit on my side and merge it later on ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes insecure hash algorithms (MD5 and SHA1) and fixes resource leaks in the file upload and zip download
functionality.
Changes
Security Improvements
function
filepath.Clean()to sanitize paths and prevent directory traversal attacksBug Fixes
defer dst.Close()to ensure uploaded files are properly closeddefer file.Close()to explicitfile.Close()to avoidaccumulating file handles in the
filepath.WalkloopCode Quality
io/ioutiltoioin test code (Go 1.16+)Testing
Breaking Changes
md5orsha1will now return an error. Users should update to usesha256orsha512.Checklist