feat: Windows Signing#80
Merged
Merged
Conversation
Rishabh4275
requested review from
CoderHam,
gauravagerwala and
pulkitjuneja
as code owners
July 17, 2025 08:59
Rishabh4275
force-pushed
the
windowsSigning
branch
from
July 17, 2025 09:09
c7d5906 to
6cbf71c
Compare
gauravagerwala
previously approved these changes
Jul 25, 2025
Rishabh4275
force-pushed
the
windowsSigning
branch
from
August 2, 2025 01:10
6cbf71c to
601fafb
Compare
Rishabh4275
force-pushed
the
windowsSigning
branch
4 times, most recently
from
August 3, 2025 00:16
d1ca3ba to
ad18288
Compare
Rishabh4275
force-pushed
the
windowsSigning
branch
17 times, most recently
from
August 9, 2025 11:19
b920121 to
8bc8ee8
Compare
Rishabh4275
force-pushed
the
windowsSigning
branch
3 times, most recently
from
August 9, 2025 11:51
eebe862 to
811b9fc
Compare
Rishabh4275
force-pushed
the
windowsSigning
branch
from
August 9, 2025 11:56
811b9fc to
597d302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Windows signing steps to the GitHub Actions workflow publish.yml. The workflow now builds the Windows executable, uploads the unsigned installer as an artifact, signs it using SignPath, updates the latest.yml metadata with the signed artifact details, and publishes both the signed executable and updated metadata to a draft release.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
By running the release pipeline and publishing a draft version.
Screenshots
If applicable, add screenshots to help explain your changes.
Checklist: