Skip to content

feat: Windows Signing#80

Merged
Rishabh4275 merged 2 commits into
mainfrom
windowsSigning
Aug 9, 2025
Merged

feat: Windows Signing#80
Rishabh4275 merged 2 commits into
mainfrom
windowsSigning

Conversation

@Rishabh4275

@Rishabh4275 Rishabh4275 commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds Windows signing steps to the GitHub Actions workflow publish.yml. The workflow now builds the Windows executable, uploads the unsigned installer as an artifact, signs it using SignPath, updates the latest.yml metadata with the signed artifact details, and publishes both the signed executable and updated metadata to a draft release.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring (no functional changes)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
By running the release pipeline and publishing a draft version.

Screenshots

If applicable, add screenshots to help explain your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested the app on Mac OS (If not, leave unchecked so we can test before merging)
  • I have tested the app on Windows (If not, leave unchecked so we can test before merging)
  • I have tested the app on Linux (If not, leave unchecked so we can test before merging)

gauravagerwala
gauravagerwala previously approved these changes Jul 25, 2025
@Rishabh4275 Rishabh4275 changed the title feat: Windows Signing [Not ready to merge] feat: Windows Signing Aug 2, 2025
@Rishabh4275
Rishabh4275 force-pushed the windowsSigning branch 4 times, most recently from d1ca3ba to ad18288 Compare August 3, 2025 00:16
@Rishabh4275
Rishabh4275 force-pushed the windowsSigning branch 17 times, most recently from b920121 to 8bc8ee8 Compare August 9, 2025 11:19
@Rishabh4275
Rishabh4275 force-pushed the windowsSigning branch 3 times, most recently from eebe862 to 811b9fc Compare August 9, 2025 11:51
@Rishabh4275
Rishabh4275 merged commit 93494b4 into main Aug 9, 2025
5 checks passed
@Rishabh4275
Rishabh4275 deleted the windowsSigning branch August 9, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants