Update .environment with Fastly credentials - #118
Open
dman-coders wants to merge 1 commit into
Open
Conversation
Add environment variables for Fastly API credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Fastly credentials automatically from the environment
Description
On Upsun hosting we provide $FASTLY_API_SERVICE as an environment variable.
This needs to be absorbed by the Magento app to be different in
productionandstagingMagento allows setting overrides with carefully structured environment variables.
https://experienceleague.adobe.com/en/docs/commerce-operations/configuration-guide/paths/override-config-settings
This change maps the conventional $FASTLY_API_SERVICE and $FASTLY_API_TOKEN to the Magento-specific format
Related Issue
Support setting Fastly API credentials directly from environment context. #117
#117
https://app.getguru.com/card/TGzyd45c/Magento2-onboarding#POhv8tRnfC3j
Motivation and Context
There is a high risk that syncing the DB state from production to staging will mean that staging has access to the production Fastly service, and may publish vcl updates from test to live inadvertently.
How Has This Been Tested?
bin/magento config:show | grep fastly.environmentfile and redeployed.(did not use an actual Fastly service for this test)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following list, and put an
xin all the boxes that apply. If you're unsure about what any of these mean, don't hesitate to ask. We're here to help!