Improve ux for biologist - #2
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and UI labels for the VDJ integration block to improve clarity, including the addition of descriptive tooltips for several configuration options. A functional issue was identified in the UI where a tooltip was added without a trigger element, which would prevent it from being displayed to the user.
Comment on lines
+170
to
+176
| <PlTooltip class="info" position="top"> | ||
| <template #tooltip> | ||
| Turn off only when the two datasets use different V/J gene naming conventions — for | ||
| example, a dataset brought in through the Import VDJ Data block, which preserves the | ||
| source pipeline's original gene names. | ||
| </template> | ||
| </PlTooltip> |
There was a problem hiding this comment.
The PlTooltip component is a wrapper that requires a trigger element in its default slot to be visible and interactive. Since it is currently empty, the tooltip will not appear. Adding an icon like PlMaskIcon24 inside the component will provide a visual target for the user to hover over.
<PlTooltip position="top">
<PlMaskIcon24 name="info" class="info" />
<template #tooltip>
Turn off only when the two datasets use different V/J gene naming conventions — for
example, a dataset brought in through the Import VDJ Data block, which preserves the
source pipeline's original gene names.
</template>
</PlTooltip>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.