MILAB-6564: update graph-maker with increased line width - #35
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates @milaboratories/graph-maker to version 1.6.1 and upgrades several @platforma-sdk workspace dependencies. Additionally, it configures the scatterplot chart in GraphPage.vue to use a default palette of "bright". No review comments were provided, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR upgrades
@milaboratories/graph-makerfrom v1.4.2 to v1.6.1 (the key change, which brings increased line width) and bumps several related@platforma-sdkand@milaboratoriespackages to their latest patch/minor versions. It also migrates the GitHub Actions CI runner fromubuntu-latestto the internal self-hostedhz-ubuntu-dindrunner and wires up the corresponding HZ-prefixed S3 Turbo cache credentials.ui/src/pages/GraphPage.vue: Addsdefault-palette="bright"to the<GraphMaker>component, applying the bright color scheme by default on the scatterplot view.pnpm-workspace.yaml/pnpm-lock.yaml: Bumps@milaboratories/graph-maker(1.4.2→1.6.1),@platforma-sdk/block-tools(2.12.0→2.12.3),@platforma-sdk/test(1.79.29→1.79.33),@platforma-sdk/workflow-tengo(6.7.0→6.7.1), and several transitive dependencies..github/workflows/build.yaml: Switches theinitjob runner tohz-ubuntu-dindand addsgha-runner-labelplus HZ S3 Turbo/cache secret variables to the workflow call.Confidence Score: 5/5
Safe to merge — the changes are limited to a dependency bump, a single new UI prop, and CI runner migration, all of which are self-contained and low-risk.
The UI change is a single prop addition (
default-palette="bright") that is directly supported by the upgradedgraph-maker1.6.1. The dependency upgrades are patch/minor bumps with consistent peer dependency resolution across the lockfile. The CI migration tohz-ubuntu-dindadds the matchinggha-runner-labeland required HZ S3 credentials without removing existing AWS variables.No files require special attention. The lockfile and workspace catalog are in sync, and the workflow secrets are passed via
toJSONthe same way as existing credentials.Important Files Changed
default-palette="bright"prop to GraphMaker component; no other logic changes.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[PR: MILAB-6564] --> B[Dependency Upgrades] A --> C[UI Change] A --> D[CI Infrastructure] B --> B1["@milaboratories/graph-maker\n1.4.2 → 1.6.1"] B --> B2["@platforma-sdk/block-tools\n2.12.0 → 2.12.3"] B --> B3["@platforma-sdk/workflow-tengo\n6.7.0 → 6.7.1"] B --> B4["@platforma-sdk/test\n1.79.29 → 1.79.33"] B --> B5["@platforma-sdk/tengo-builder\n4.0.15 → 4.0.16"] B1 --> T1["Transitive: miplots4 1.2.0→1.4.0\npf-plots 1.4.1→1.5.0\npl-client 3.13.2→3.14.0\npl-middle-layer 1.65.4→1.65.8"] C --> C1["GraphPage.vue\nAdd default-palette='bright'\nto GraphMaker component"] D --> D1["Runner: ubuntu-latest\n→ hz-ubuntu-dind"] D --> D2["Add gha-runner-label param"] D --> D3["Add HZ S3 Turbo cache\ncredentials to workflow"]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[PR: MILAB-6564] --> B[Dependency Upgrades] A --> C[UI Change] A --> D[CI Infrastructure] B --> B1["@milaboratories/graph-maker\n1.4.2 → 1.6.1"] B --> B2["@platforma-sdk/block-tools\n2.12.0 → 2.12.3"] B --> B3["@platforma-sdk/workflow-tengo\n6.7.0 → 6.7.1"] B --> B4["@platforma-sdk/test\n1.79.29 → 1.79.33"] B --> B5["@platforma-sdk/tengo-builder\n4.0.15 → 4.0.16"] B1 --> T1["Transitive: miplots4 1.2.0→1.4.0\npf-plots 1.4.1→1.5.0\npl-client 3.13.2→3.14.0\npl-middle-layer 1.65.4→1.65.8"] C --> C1["GraphPage.vue\nAdd default-palette='bright'\nto GraphMaker component"] D --> D1["Runner: ubuntu-latest\n→ hz-ubuntu-dind"] D --> D2["Add gha-runner-label param"] D --> D3["Add HZ S3 Turbo cache\ncredentials to workflow"]Reviews (1): Last reviewed commit: "update graph-maker" | Re-trigger Greptile
Context used: