fix(ci): PR builds use build:dev-local, publish uses build:release - #34
Merged
Conversation
The structurer migration left build-script-name pointing at build:release, so PR/merge-queue validation ran the release channel (remote software upload). Validate PRs locally with build:dev-local and keep the release build for the publish leg via build-before-publish-script-name.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The structurer migration (#32) left the build workflow calling
build:releasefor all builds:So PR and merge-queue validation runs the release channel — remote software upload — which is wrong for validating a PR.
(Root cause was upstream: block-tools'
build.tpl.yamloriginally generatedbuild-script-name: 'build', a script the structurer had removed. Fixed the template in platforma#1744; this PR applies the correct config to rarefaction now.)Fix
The reusable
node-simple-pnpm.yamlhas two build legs — PR/test (build-script-name) and publish (build-before-publish-script-name). Wire each to the right flavor:Once block-tools#1744 ships and rarefaction bumps the SDK, a
structure refreshwill regenerate exactly this — no drift.Greptile Summary
This PR fixes the CI workflow so that PR/merge-queue validation uses
build:dev-local(local, dev channel) while the publish step retainsbuild:release(remote, release channel). The prior state had a singlebuild-script-name: 'build:release'for all builds, causing every PR check to trigger a remote release-channel build — incorrect behavior left behind by the structurer migration in #32.build-script-namechanged frombuild:releasetobuild:dev-local: PR and merge-queue runs now executePL_BUILD_CHANNEL=dev PL_BUILD_LOCATION=local, keeping validation self-contained and avoiding remote software uploads.build-before-publish-script-name: 'build:release'added: publish runs continue to usePL_BUILD_CHANNEL=release PL_BUILD_LOCATION=remote, ensuring release artifacts are built with the correct channel settings.Confidence Score: 5/5
Safe to merge — both
build:dev-localandbuild:releasescripts are confirmed present in the rootpackage.json, and the parameter split correctly maps each CI leg to the right build flavor.The change is a two-line YAML correction that wires pre-existing scripts to the appropriate CI legs.
build:dev-localandbuild:releaseboth exist at the repo root and have the expected env-var combinations. No logic is altered elsewhere.No files require special attention.
Important Files Changed
build-script-name: 'build:release'into the correct two-parameter setup:build:dev-localfor PR/merge-queue andbuild:releasefor publish. Both scripts are confirmed present in rootpackage.json.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[GitHub Event] --> B{Event Type?} B -->|pull_request / merge_group| C[build-script-name\nbuild:dev-local] B -->|push to main / publish| D[build-before-publish-script-name\nbuild:release] C --> E[PL_BUILD_CHANNEL=dev\nPL_BUILD_LOCATION=local\nturbo run build] D --> F[PL_BUILD_CHANNEL=release\nPL_BUILD_LOCATION=remote\nturbo run build] E --> G[Local validation — no remote upload] F --> H[Release artifacts published remotely]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[GitHub Event] --> B{Event Type?} B -->|pull_request / merge_group| C[build-script-name\nbuild:dev-local] B -->|push to main / publish| D[build-before-publish-script-name\nbuild:release] C --> E[PL_BUILD_CHANNEL=dev\nPL_BUILD_LOCATION=local\nturbo run build] D --> F[PL_BUILD_CHANNEL=release\nPL_BUILD_LOCATION=remote\nturbo run build] E --> G[Local validation — no remote upload] F --> H[Release artifacts published remotely]Reviews (1): Last reviewed commit: "fix(ci): PR builds use build:dev-local, ..." | Re-trigger Greptile
Context used: