Skip to content

Replace storageFormat with Parquet and upgrade workflow-tengo - #119

Merged
kevindetry-milaboratories merged 1 commit into
mainfrom
push-wwynurwxuqwn
Jul 12, 2026
Merged

Replace storageFormat with Parquet and upgrade workflow-tengo#119
kevindetry-milaboratories merged 1 commit into
mainfrom
push-wwynurwxuqwn

Conversation

@kevindetry-milaboratories

@kevindetry-milaboratories kevindetry-milaboratories commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR migrates all pfconvParams storage format configurations from "Binary" to "Parquet" across six call sites in the workflow Tengo code, and upgrades @platforma-sdk/workflow-tengo from 6.6.5 to 6.7.1 (along with transitive updates to software-ptabler and software-ptexter).

  • storageFormat migration: All six occurrences of storageFormat: "Binary" in export-settings.lib.tengo (functions shmTree, shmTreeNodes, shmTreeNodesWithClones, shmTreeNodesUniqueIsotype) and soi.tpl.tengo (resultConvParams, aggregatedConvParams) are updated to "Parquet". No "Binary" references remain in the codebase.
  • Dependency upgrade: @platforma-sdk/workflow-tengo bumped to 6.7.1, which pulls in updated software-ptabler@2.1.5 and software-ptexter@1.2.3 as transitive dependencies.

Confidence Score: 5/5

The change is safe to merge — it consistently replaces all six Binary storage format references with Parquet and aligns the SDK version across the workspace catalog and lock file with no missing sites.

All storageFormat occurrences across the two affected files are updated; a grep of the full workflow/src directory confirms no Binary references remain. The lock file is internally consistent with the workspace catalog bump. The transitive dependency upgrades are minor patch increments pulled in automatically by the SDK version bump.

No files require special attention.

Important Files Changed

Filename Overview
workflow/src/export-settings.lib.tengo All four storageFormat: "Binary" occurrences replaced with "Parquet" in shmTree, shmTreeNodes, shmTreeNodesWithClones, and shmTreeNodesUniqueIsotype — migration appears complete and consistent.
workflow/src/soi.tpl.tengo Both storageFormat: "Binary" occurrences (resultConvParams, aggregatedConvParams) replaced with "Parquet" — consistent with the export-settings changes.
pnpm-workspace.yaml Catalog version for @platforma-sdk/workflow-tengo bumped from ^6.6.5 to ^6.7.1.
pnpm-lock.yaml Lock file updated to resolve workflow-tengo@6.7.1, software-ptabler@2.1.5, and software-ptexter@1.2.3 — lock is internally consistent with the workspace catalog.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Workflow Tengo 6.7.1] --> B[export-settings.lib.tengo]
    A --> C[soi.tpl.tengo]

    B --> D[shmTree\npfconvParams]
    B --> E[shmTreeNodes\npfconvParams]
    B --> F[shmTreeNodesWithClones\npfconvParams]
    B --> G[shmTreeNodesUniqueIsotype\npfconvParams]

    C --> H[resultConvParams]
    C --> I[aggregatedConvParams]

    D --> J["storageFormat: Parquet\n(was: Binary)"]
    E --> J
    F --> J
    G --> J
    H --> J
    I --> J

    J --> K[pframes conversion\nsoftware-ptabler@2.1.5\nsoftware-ptexter@1.2.3]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Workflow Tengo 6.7.1] --> B[export-settings.lib.tengo]
    A --> C[soi.tpl.tengo]

    B --> D[shmTree\npfconvParams]
    B --> E[shmTreeNodes\npfconvParams]
    B --> F[shmTreeNodesWithClones\npfconvParams]
    B --> G[shmTreeNodesUniqueIsotype\npfconvParams]

    C --> H[resultConvParams]
    C --> I[aggregatedConvParams]

    D --> J["storageFormat: Parquet\n(was: Binary)"]
    E --> J
    F --> J
    G --> J
    H --> J
    I --> J

    J --> K[pframes conversion\nsoftware-ptabler@2.1.5\nsoftware-ptexter@1.2.3]
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
workflow/src/export-settings.lib.tengo:250-258
**Key terms touched by this PR**

The following terms are central to the changes in this PR:

- **`storageFormat`** — A field within `pfconvParams` that controls how converted pframes data is persisted on disk. Previously set to `"Binary"` (a proprietary binary layout); now set to `"Parquet"` (a columnar open format) in all six call sites across `export-settings.lib.tengo` and `soi.tpl.tengo`.

- **`pfconvParams`** — The parameter object passed to the pframes conversion step. It groups `axes`, `columns`, `storageFormat`, and `partitionKeyLength` into a single configuration that describes how tabular output is serialized. Updated indirectly via the `storageFormat` change.

- **`workflow-tengo`** (`@platforma-sdk/workflow-tengo`) — The core Tengo workflow SDK that orchestrates all pipeline steps. Bumped from `6.6.5``6.7.1`; the new minor release is what makes `"Parquet"` the expected (and presumably required) format.

- **`software-ptabler`** (`@platforma-open/milaboratories.software-ptabler`) — A transitive dependency of `workflow-tengo` responsible for tabular data operations. Updated from `2.1.3``2.1.5` as part of the SDK bump.

- **`software-ptexter`** (`@platforma-open/milaboratories.software-ptexter`) — A transitive dependency of `workflow-tengo` handling text/sequence column encoding. Updated from `1.2.2``1.2.3` as part of the SDK bump.

- **`shmTree` / `shmTreeNodes` / `shmTreeNodesWithClones` / `shmTreeNodesUniqueIsotype`** — Export-settings factory functions building `pfconvParams` + `cmdArgs` for different SHM-tree table views. All four had `storageFormat` updated from `"Binary"` to `"Parquet"`.

- **`resultConvParams` / `aggregatedConvParams`** — Inline conversion-parameter objects in `soi.tpl.tengo` for the SOI search result table and its aggregated counterpart. Both had `storageFormat` updated from `"Binary"` to `"Parquet"`.

Reviews (1): Last reviewed commit: "Replace storageFormat with Parquet and u..." | Re-trigger Greptile

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @platforma-sdk/workflow-tengo dependency to version 6.7.1 and changes the storageFormat configuration from "Binary" to "Parquet" in several Tengo workflow scripts, including export-settings.lib.tengo and soi.tpl.tengo. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kevindetry-milaboratories
kevindetry-milaboratories added this pull request to the merge queue Jul 12, 2026
Merged via the queue into main with commit 9b6e2a9 Jul 12, 2026
11 checks passed
@kevindetry-milaboratories
kevindetry-milaboratories deleted the push-wwynurwxuqwn branch July 12, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant