Milab 6738 vdj import chain match - #46
Merged
Merged
Conversation
…ross all data formats in import-vdj-data
Output of `pnpm run upgrade-sdk`. No handwritten changes in this commit. Layout .structure v1 -> v2. Root build/build:dev scripts are replaced by the PL_BUILD_* matrix, hence build.yaml's build-script-name 'build' -> 'build:dev-local'.
Column discovery now passes 'dontWaitAllData' so stats columns without data are skipped instead of collapsing the request to 'undefined'.
julenmendieta
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
093dfc2chain matching fixeac8d71purepnpm run upgrade-sdkoutput, no hand-written changes7430875fixes the upgrade forced (3 small ones)f8dba62changeset for the upgradeb6a6ed5empty-import warning + stats table fixGreptile Summary
This PR upgrades the Platforma SDK and block structure, broadens V(D)J chain matching, and adds user-facing detection of samples left without clonotypes.
emptyChainSamplesmodel output and warning banner for samples whose summed clonotype count is zero.Important touched terms
IGH,IGK,TRA, orTRB. Custom and ImmunoSeq now search for this token anywhere in the uppercased gene value.dontWaitAllData, and only ready columns are passed to the table.BlockPointerandImportVdjBlockPointerusing URLs derived fromimport.meta.url.PL_BUILD_*variables.Confidence Score: 5/5
The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects established in the changed code.
The chain normalization follows the documented cross-format behavior, the warning and table changes are coherently connected to statistics outputs, and no accepted failures remain.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Imported VDJ rows] --> B[Normalize chain-defining value] B --> C[Filter rows by requested receptor chain] C --> D[Generate per-chain clonotypes and statistics] D --> E[Expose statistics as p-columns] E --> F[Sum clonotype counts per sample] F --> G{Total is zero?} G -- Yes --> H[Show empty-sample warning] G -- No --> I[Render statistics table]Reviews (1): Last reviewed commit: "MILAB-6738: warn when chain filtering le..." | Re-trigger Greptile
Context used: