Skip to content

dependencies update - #106

Closed
vgpopov wants to merge 2 commits into
mainfrom
MILAB-4837-deps-update
Closed

dependencies update#106
vgpopov wants to merge 2 commits into
mainfrom
MILAB-4837-deps-update

Conversation

@vgpopov

@vgpopov vgpopov commented Nov 27, 2025

Copy link
Copy Markdown

dependencies update

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @vgpopov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading a key project dependency, @platforma-sdk/workflow-tengo, to its latest major version. This update aims to incorporate new features, performance improvements, and bug fixes from the updated package, ensuring the project leverages the most current capabilities.

Highlights

  • Dependency Update: The @platforma-sdk/workflow-tengo dependency has been updated from version 3.0.1 (or ^3.0.1) to ^5.6.2.
  • Configuration Files: The version bump for @platforma-sdk/workflow-tengo is reflected in both pnpm-lock.yaml and pnpm-workspace.yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @platforma-sdk/workflow-tengo dependency from v3 to v5. This is a major version change that could introduce breaking changes. I've left a comment regarding the need for more details in the pull request description to mitigate the risks associated with this upgrade. Additionally, I've found a critical inconsistency in the pnpm-lock.yaml file, which suggests the dependency update process was not completed correctly. Please address these points.

Comment thread pnpm-lock.yaml Outdated
'@platforma-sdk/block-tools': 2.5.68
'@platforma-sdk/model': 1.24.0
'@platforma-sdk/workflow-tengo': 3.0.1
'@platforma-sdk/workflow-tengo': ^5.6.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There appears to be an inconsistency in this lock file. While this line reflects the updated version of @platforma-sdk/workflow-tengo, the catalogs section at the top of the file still references the old version (^3.0.1).

# pnpm-lock.yaml:42
'@platforma-sdk/workflow-tengo':
  specifier: ^3.0.1
  version: 3.0.1

This indicates that pnpm install may not have been run or completed successfully after modifying pnpm-workspace.yaml. An inconsistent lock file is a critical issue that can cause incorrect dependencies to be installed. Please run pnpm install to regenerate the lock file correctly and commit the full set of changes.

Comment thread pnpm-workspace.yaml Outdated

catalog:
'@platforma-sdk/workflow-tengo': ^3.0.1
'@platforma-sdk/workflow-tengo': ^5.6.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version bump for @platforma-sdk/workflow-tengo from v3 to v5, which could introduce breaking changes. The pull request description is very brief. To ensure a safe upgrade, please update the description to include:

  • The reasoning behind this major upgrade.
  • A summary of any breaking changes and how they are addressed.
  • Details on how this change was tested to ensure it doesn't break dependent packages like workflow.

@vgpopov vgpopov closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants