Skip to content

Make table and graph outputs retentive - #95

Open
kevindetry-milaboratories wants to merge 1 commit into
mainfrom
push-ttyumupvvszo
Open

Make table and graph outputs retentive#95
kevindetry-milaboratories wants to merge 1 commit into
mainfrom
push-ttyumupvvszo

Conversation

@kevindetry-milaboratories

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kevindetry-milaboratories, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the persistence of table and graph outputs within the clonotype-clustering model. By switching to retentiveOutputWithStatus, the application will now preserve the state of the clustersTable, clustersPf, and bubblePlotPf outputs, improving user experience by maintaining context across sessions.

Highlights

  • Output Persistence: The primary change involves modifying the clustersTable, clustersPf, and bubblePlotPf outputs to be retentive. This means that the state of these outputs will be preserved across sessions or interactions.
  • Code Modification: The outputWithStatus calls for clustersTable, clustersPf, and bubblePlotPf have been replaced with retentiveOutputWithStatus.
  • Changeset: A changeset file (.changeset/gentle-taxes-knock.md) has been added to document this change.
Changelog
  • .changeset/gentle-taxes-knock.md
    • Added changeset to document the change of making table and graph outputs retentive.
  • model/src/index.ts
    • Replaced outputWithStatus with retentiveOutputWithStatus for clustersTable, clustersPf, and bubblePlotPf to make these outputs retentive.
Activity
  • The pull request introduces a new changeset file.
  • The pull request modifies the model/src/index.ts file to update the output methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the clustersTable, clustersPf, and bubblePlotPf outputs retentive. This is a good improvement for the user experience. However, I've identified a pre-existing critical bug in the implementation of the bubblePlotPf output where it has a recursive definition. This will prevent it from functioning correctly. I've left a comment with details on the issue.

Comment thread model/src/index.ts
Base automatically changed from push-mxmyttvvswrq to main February 4, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant