Set default block label - #91
Conversation
Summary of ChangesHello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the user experience by setting a descriptive default label for a block component, guiding users to select a dataset. Concurrently, it incorporates routine updates to various project dependencies, upgrading several core Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request sets a more descriptive default block label, which is a nice improvement. However, it also bundles dependency updates for several packages. The pull request title and description only mention the label change, which can be misleading. For better maintainability and easier reviews, it's recommended to separate dependency updates into their own pull requests. I've left a specific comment with a suggestion on how to address this.
| '@platforma-sdk/model': 1.51.9 | ||
| '@platforma-sdk/ui-vue': 1.51.9 | ||
| '@platforma-sdk/tengo-builder': 2.4.8 | ||
| '@platforma-sdk/package-builder': 3.11.0 | ||
| '@platforma-sdk/block-tools': 2.6.29 | ||
| '@platforma-sdk/eslint-config': 1.2.0 | ||
| '@platforma-sdk/test': 1.51.6 | ||
| '@platforma-sdk/test': 1.51.9 | ||
| '@milaboratories/helpers': 1.13.0 | ||
|
|
||
| # Block-specific dependencies | ||
| '@milaboratories/graph-maker': ^1.1.211 | ||
| '@milaboratories/multi-sequence-alignment': '^1.45.10' | ||
| '@milaboratories/graph-maker': ^1.1.213 | ||
| '@milaboratories/multi-sequence-alignment': '^1.45.11' |
There was a problem hiding this comment.
This pull request updates several dependencies in the workspace catalog. While keeping dependencies up-to-date is important, the title of this PR ("Set default block label") doesn't mention these changes. This can make it difficult to track dependency updates in the project's history.
It's generally better to handle dependency updates in a separate pull request with a clear title (e.g., "chore(deps): update dependencies"). This makes reviews more focused and rollbacks safer.
Could you please either:
- Update the title and description of this PR to reflect the dependency updates.
- (Preferred) Revert the dependency updates from this PR and create a separate one for them.
Set default block label