chore: restore mark-stable script on the block facade - #45
Merged
Conversation
The "Mark Platforma Block as Stable" workflow fails with
`ERR_PNPM_NO_SCRIPT Missing script: mark-stable`: the reusable
`milaboratory/github-ci/.github/workflows/block-mark-stable.yaml@v4`
does `cd "${BLOCK_PATH}"` (default `block`) and then
`pnpm run mark-stable`, but the script was dropped from
`block/package.json` during the project-template migration.
Restore it with the same registry coordinates `prepublishOnly` uses.
The structurer currently strips this script again on
`block-tools structure refresh`; a companion change in `block-tools`
removes that `removeScript` call.
Empty changeset: the published block content is unchanged — this is a
repo-side CI script only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Mark Platforma Block as Stableworkflow fails:Failing run
The reusable
milaboratory/github-ci/.github/workflows/block-mark-stable.yaml@v4does:block/package.jsonlost that script inf54d8fe("SDK Upgrade, fix page title"), during the migration to the new project template. The rootmark-stable(turbo run mark-stable) is not a substitute: CI never runs it, and no workspace package implements the turbo task.Change
Restore
mark-stableon the facade, with the same registry coordinatesprepublishOnlyalready uses.The changeset is intentionally empty: the published block content does not change, this is a repo-side CI script only.
Note
block-tools structure refreshcurrently strips this script again — the facade rule carries an unconditionalremoveScript("mark-stable"). A companion PR removes that call: milaboratory/platforma#1790. Merge order does not matter for this PR to fix the workflow, but the script will not stay put until the block-tools change ships.Greptile Summary
Restores the block-facade script required by the reusable mark-stable workflow without changing published block content.
mark-stable— A package script that invokesblock-tools mark-stableto mark a block release as stable in the configured S3 registry. This PR restores it inblock/package.jsonusing the registry coordinates already used for publishing.blockworkspace package from which reusable block workflows execute package scripts. Its script surface now exposesmark-stableagain.Confidence Score: 5/5
The PR appears safe to merge because the restored script matches the documented workflow entry point and no actionable defect was identified.
The workflow can again invoke
mark-stablefrom the block facade, while the empty changeset follows the repository’s documented waiver for changes that do not alter published package content.Important Files Changed
mark-stablescript expected by the reusable workflow, targeting the same registry used by the existing publish script.Sequence Diagram
sequenceDiagram participant CI as Mark Stable Workflow participant Facade as block/package.json participant Tools as block-tools participant Registry as S3 Block Registry CI->>Facade: pnpm run mark-stable Facade->>Tools: "block-tools mark-stable -r <registry>" Tools->>Registry: Mark block release stableReviews (1): Last reviewed commit: "chore: restore mark-stable script on the..." | Re-trigger Greptile