Milab 6848 fix sc tcr chain labels - #40
Open
mchernys wants to merge 3 commits into
Open
Conversation
cdr3-spectratype now uses the scClonotypeChain domain letter everywhere, with the workflow's TCR swap gone and the selector kept in classic order (Alpha=B, Beta=A). The block was already picking the right chain, so the real bug was just a wrong letter in the exported label; the cost is that existing single-cell TCR blocks re-run on the opposite chain.
Since the chain letters changed meaning in the preceding commits, cached results will not match the chain in the settings. A stored "A" ran as an Alpha, but now it reads as a Beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR aligns single-cell receptor-chain selection with the
pl7.app/vdj/scClonotypeChainproducer domain and replaces raw chain letters with biological names in generated labels.Important touched terms
ScChain— The persisted"A" | "B"single-cell chain-domain value. Its documented meaning is clarified:Arepresents Heavy/Beta/Delta, whileBrepresents Light/Alpha/Gamma.BlockArgs.scClonotypeChain— The workflow-facing selected domain letter. It replaces the ambiguousscChainargument so the convention is explicit and intentionally invalidates stale executions.pl7.app/vdj/scClonotypeChain— The source-column domain used to distinguish paired receptor chains. The workflow now compares the selected letter directly instead of inverting TCR letters.chainName— The receptor-specific biological display name derived from a chain letter. Generated V and CDR3 spectratype labels now use names such as Alpha, Beta, Heavy, and Light.scChainNames— The workflow mapping from receptor and domain letter to biological chain name.Band Beta/Delta useA, while retaining the conventional biological display order.@platforma-sdk/block-toolsmoves from 2.12.6 to 2.14.3 and@platforma-sdk/tengo-builderfrom 4.0.18 to 4.0.23, with corresponding lockfile updates.Confidence Score: 5/5
The PR appears safe to merge because the model, UI, and workflow consistently use the corrected chain-domain convention.
The selected domain letter is projected consistently, matched directly against primary source columns, and translated to the corresponding biological name only for display; no blocking failure remains.
Important Files Changed
scClonotypeChainworkflow argument name.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR U[UI chain option] -->|Alpha/Gamma = B<br/>Beta/Delta = A| D[scClonotypeChain domain letter] D --> P[Model argument projection] P --> W[Workflow source-column predicate] W --> C[Matching primary CDR3 and V-gene columns] D --> N[Receptor-specific chain-name mapping] N --> L[Biological output labels] C --> R[Spectratype results] L --> RReviews (1): Last reviewed commit: "MILAB-6848: rename the args chain field ..." | Re-trigger Greptile
Context used (5)