Allow unions to have metadata#312
Open
parched wants to merge 2 commits into
Open
Conversation
Collaborator
|
I don't like just parsing and then throwing out the metadata. It at least needs to go into the cst, so the formatter can see it. I also think it makes sense to validate it (and then reject it because we don't understand it). |
Collaborator
|
Are you still interested in finishing this? :) |
Contributor
Author
|
I will get around to it when I have some spare time, but I'm more than happy if someone else wants to pick it up. |
Allow parsing union variant metadata, preserve it in CST/formatter, and reject it semantically * Parse and keep metadata on union variants in the CST so formatting can round-trip it. * Update formatter handling so union variant metadata is visible to formatting logic instead of being discarded. * Add semantic validation that rejects union variant metadata with a clear error. * Current behavior: union variant metadata syntax is accepted by the parser, but no metadata keys are supported semantically yet. Note: AI was used in some of this.
Contributor
Author
|
@TethysSvensson I've finally updated the PR to handle the variant metadata in the CST/formatter. Note: I used AI for some of this. Hope that's alright! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this doesn't do anything with the metadata,
but it's useful for sharing the schema with another tool that does use them.
It's unclear to how I should add a test for this.
It's not considered entirely valid because the attributes are unknown (I ignore these errors for my fbs files)
Checklist