Reject encoded separators in non-greedy path parameters - #310
Merged
ringabout merged 1 commit intoSep 7, 2026
Merged
Conversation
ringabout
approved these changes
Sep 7, 2026
ringabout
left a comment
Member
There was a problem hiding this comment.
Reviewed PR #310 against devel. The guard is applied before storing non-greedy captures, handles case-insensitive %2F/%5C, and leaves greedy parameters and double-encoded values unchanged. Focused tests pass on the default and -d:usestd backends. The regex-route behavior is pre-existing and can be followed up separately. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
nim c -r tests/mock/tmock_mocking/tmock_route.nimnim c -r -d:usestd tests/mock/tmock_mocking/tmock_route.nimnimble testsFixes #296