Skip to content

#1213 - Support geom_ref in list_subscriptions#1215

Merged
tbarsballe merged 3 commits into
planetlabs:mainfrom
tbarsballe:1213-1214-fix-missing-feats
Jun 10, 2026
Merged

#1213 - Support geom_ref in list_subscriptions#1215
tbarsballe merged 3 commits into
planetlabs:mainfrom
tbarsballe:1213-1214-fix-missing-feats

Conversation

@tbarsballe

@tbarsballe tbarsballe commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Related Issue(s):

Closes #1213

Sorry for the two fixes in one MR, but I'm also using this branch as a local build of the SDK while I wait for these fixes to be accepted and released.

Edit: Scaling this back to just 1213, turns out update_feature can't touch geometry, and therefore isn't useful to me.

Proposed Changes:

For inclusion in changelog (if applicable):

  1. geom_ref now supported by list_subscriptions

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

@tbarsballe

Copy link
Copy Markdown
Contributor Author

Not sure I understand the typing failure here, if anyone's got some insight it would be appreciated

@tbarsballe tbarsballe changed the title Draft: #1213, #1214 - Support geom_ref in list_subscriptions, Add update_feature support for feature client(s) Draft: #1213 - Support geom_ref in list_subscriptions Jun 8, 2026
@tbarsballe tbarsballe changed the title Draft: #1213 - Support geom_ref in list_subscriptions #1213 - Support geom_ref in list_subscriptions Jun 8, 2026
@tbarsballe

Copy link
Copy Markdown
Contributor Author

Okay, I did a rerun of the typing check on main (which passed on the latest commit, when it was run about a month ago), and it failed this time around, with no code changes since the passed test.
Seems like somewhere in the dependency tree of our type checker, something's been released that now causes these failures, entirely unrelated to the changes in this MR.

@tbarsballe

Copy link
Copy Markdown
Contributor Author

Found the issue, reported as #1218
I've included a patch here to fix CI for this PR.

@asonnenschein asonnenschein left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbarsballe tbarsballe merged commit 490e795 into planetlabs:main Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support geom_ref for SubscriptionsClient.list_subscriptions

2 participants