#1213 - Support geom_ref in list_subscriptions#1215
Merged
tbarsballe merged 3 commits intoJun 10, 2026
Conversation
Contributor
Author
|
Not sure I understand the typing failure here, if anyone's got some insight it would be appreciated |
Contributor
Author
|
Okay, I did a rerun of the typing check on main (which passed on the latest commit, when it was run about a month ago), and it failed this time around, with no code changes since the passed test. |
Contributor
Author
|
Found the issue, reported as #1218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Closes #1213
Sorry for the two fixes in one MR, but I'm also using this branch as a local build of the SDK while I wait for these fixes to be accepted and released.Edit: Scaling this back to just 1213, turns out update_feature can't touch geometry, and therefore isn't useful to me.
Proposed Changes:
For inclusion in changelog (if applicable):
PR Checklist:
(Optional) @mentions for Notifications: