test(drawnix): add shared testing board fixture - #468
Merged
Conversation
Deploying drawnix with
|
| Latest commit: |
a220563
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://523e852a.drawnix.pages.dev |
| Branch Preview URL: | https://nightt5879-issue-453-testing.drawnix.pages.dev |
Member
Author
|
@pubuzhixing8 The current CI failure is caused by the Plait dependency version: \createBoardEventObserver()\ was merged in worktile/plait#1163, but it is not available in the published @plait/core@0.93.4\ yet. This PR passes locally against the Plait \develop\ build. Could you please publish/update Plait, or let me know which version Drawnix should target? Once that version is available, I can update the Drawnix dependencies and rerun CI. |
Contributor
|
@nightt5879 0.94.0 is live now! |
nightt5879
marked this pull request as ready for review
September 7, 2026 06:45
pubuzhixing8
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupDrawnixTestingBoard()wrapper around Plait'ssetupTestingBoard()appState, with optional pointer and creation-mode overridescreateBoardEventObserver()The helper remains under
packages/drawnix/testing/and is not exported from the published Drawnix package.Related Issue
Closes #453
Upstream prerequisite: worktile/plait#1163 is merged, but
createBoardEventObserver()has not yet been published in an npm release of@plait/core. This PR therefore remains a draft until Drawnix can update to that release.Validation
Evidence, screenshots, or compatibility notes:
.nvmrcnpm run lintpassesnpm run test -- --runpasses for all four workspace projects when using the local sibling Plaitdevelopbuild; Drawnix: 9 files, 26 testsnpm run buildpasses for all four workspace projectsoxfmt --checkpasses for all four changed filesnpm run format:checkreports 127 untouched files; the pull request CI formatting step passes, and no unrelated formatting was applied@plait/core@0.93.4does not yet providecreateBoardEventObserver()AI Assistance
Did you use AI tools to generate or substantially modify code, tests, or documentation in this pull request?
If yes:
Tool/model: Codex / GPT-5
AI-assisted work: Implemented the Drawnix testing wrapper, migrated the two plugin specs, and ran the local validation commands.
My review and validation: I reviewed and understood all four changed files before opening this pull request. The checks and results are recorded above.
I reviewed and understand the AI-assisted changes and can explain and maintain them
Checklist