feat(freehand): extract standalone plugin package - #467
Closed
nightt5879 wants to merge 1 commit into
Closed
Conversation
Deploying drawnix with
|
| Latest commit: |
78dc639
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://836298fd.drawnix.pages.dev |
| Branch Preview URL: | https://nightt5879-issue-464-freehan.drawnix.pages.dev |
Member
Author
|
Closing because this implementation was started prematurely during a planning discussion. No implementation decision was intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@plait-board/freehandpackageTesting
npx nx run-many -t=test --all -- --runnpm run buildnpm run lintnpm run format:checknpx nx build webnpx tsc -p packages/freehand/tsconfig.lib.json --noEmitnpx tsc -p packages/drawnix/tsconfig.lib.json --noEmitnpm pack/ install /require('@plait-board/freehand')consumer smoke testA full all-project TypeScript check still reports the existing CSS custom-property typing errors in the unchanged
island.tsxandstack.tsxfiles; the new package and Drawnix library type checks pass.AI-assisted contribution
Closes #464